-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export luma functions #8822
Export luma functions #8822
Conversation
How should a scripting application use luma 9 to register or create devices? Or in my case, call `enforceWebGL2` from a https://codesandbox.io/p/sandbox/deck-v9-maplibre-interleave-repro-8602-mapbox-v1-fork-4hwfff?file=%2Findex.html%3A16%2C1. Add `luma` namespace functions to the pre-built bundle.
I would expect this |
v9 introduced a luma namespace within the core for some static functions. I think the scripting package can export these however it wants since we can document the mapping |
Agreed, It probably makes sense to add the functions in the luma "namespace" to
I suppose the downside is that the concepts are unrelated and it could cause some minor confusion, but as @chrisgervang says it is up to us to define the mapping. |
0a083b6
to
eb85da3
Compare
Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
Background
How should a scripting application use luma 9 to register or create devices? Or in my case, call
enforceWebGL2
from a bug repro.I'm not exactly sure what the solution is, so I'm starting by proposing the simplest one. It comes with a downside that the script would access the functions with
luma.luma.createDevice
, which is not super elegant.. alternatively we could remove the nesting by spreading the functions onto the export.Change List
luma
namespace functions to the pre-built bundle.